Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcModal): make 'Close' button the last element for the focus-trap #6266

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix(NcModal): make 'Close' button the last element for the focus-trap #6266

merged 1 commit into from
Dec 6, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: modal Related to the modal component labels Nov 25, 2024
@Antreesy Antreesy added this to the 8.21.1 milestone Nov 25, 2024
@Antreesy Antreesy requested review from susnux and ShGKme November 25, 2024 19:16
@Antreesy Antreesy self-assigned this Nov 25, 2024
@Antreesy Antreesy requested a review from DorraJaouad November 25, 2024 22:16
@Antreesy Antreesy merged commit 6f2e76a into master Dec 6, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/13867/focus-first-not-close branch December 6, 2024 13:21
@Antreesy
Copy link
Contributor Author

Antreesy commented Dec 6, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: modal Related to the modal component
Projects
None yet
Milestone
8.21.1
Development

Successfully merging this pull request may close these issues.

Missing focus after clicking *Create a new conversation*
3 participants
@Antreesy @ShGKme @DorraJaouad